APIv4 - add is_current as a pseudo (calculated) field #20586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@colemanw can you rebase? |
This adds the first calculated field to APIv4. It works by injecting a SQL function and aliasing it with the name of the fake field. This approach allows it to work as part of the WHERE clause as well as the SELECT clause, even across joins. Marking the old "is_current" api param deprecated because the field works better.
|
This looks good to me and makes sense to me UTs should give us good enough cover here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds an "is_current" field to SearchKit for relationships, events & campaigns. It checks that the record is active and has a non-past end date and a non-future start date.
Technical Details
This adds the first calculated field to APIv4. It works by injecting a SQL function and aliasing it with the name of the fake field. This approach allows it to work as part of the WHERE clause as well as the SELECT clause, even across joins.
Marking the old "is_current" api param deprecated because the field works better.