Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception rather than allow php fail #20565

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jun 10, 2021

Overview

Throw exception rather than allow php fail when the api class is not found

Before

image

After

image

Technical Details

This seems to be something I hit fairly often locally - due to inconsistent states or whatever - and it's always a pain to figure out the entity in question

Comments

@civibot
Copy link

civibot bot commented Jun 10, 2021

(Standard links)

@civibot civibot bot added the master label Jun 10, 2021
@monishdeb
Copy link
Member

Patch looks good, confirmed that it fixes the notice, and rightful show exception message. Merging now

@monishdeb monishdeb merged commit 20f1d63 into civicrm:master Jun 10, 2021
@eileenmcnaughton eileenmcnaughton deleted the val_err branch October 17, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants