dev/core#2486 - Add foreign key on civicrm_contribution_product.product_id #20553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
7e29349 to
d85e65f
Compare
|
Jenkins says: |
4271b83 to
fd54d5e
Compare
|
@monishdeb can you rebase this please? |
fd54d5e to
8714d4b
Compare
|
Thanks @seamuslee001 for notifying the conflict. Rebased now. |
|
This looks good. Thanks @monishdeb |
colemanw
added a commit
to colemanw/civicrm-core
that referenced
this pull request
Jun 17, 2021
eileenmcnaughton
pushed a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jul 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add foreign key on civicrm_contribution_product.product_id
Before
No foreign key on product ID
After
Added foreign key on civicrm_contribution_product.product_id (on delete null)
Technical Details
Followup PR of #20505
Comments
ping @colemanw @eileenmcnaughton @seamuslee001
(should we target this patch after 5.39-rc cut??)