[php8-compat][REF] Fix Date unit tests in php8 by passing in 00 inste… #20525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ad of null for hours,minutes and seconds
Overview
This fixes a test failures such as
Before
Date test fails in php8
After
Date tests pass in php8
Technical Details
as per https://www.php.net/manual/en/function.mktime.php#refsect1-function.mktime-changelog the hours, minutes and seconds is now nullable and this means that if null is passed in the current time values for that section is used
ping @eileenmcnaughton @totten @demeritcowboy