Send pcp notification only when the contribution is completed #20523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
This is cleanup towards civicrm#19096 in that it gets the function out of the form layer and also makes it so it does not require a BAO. This does add one extra db lookup in some cases but I think it's pretty low volume and will mean this is not required https://github.com/civicrm/civicrm-core/pull/19096/files#diff-4c9d0b1abe07057a4eea2b47bc627eecb95face8ed8d86c1c005312a52cca811R4271-R4273
This is a reviewer's cut of civicrm#19096 the only substantive difference is the check around the contribution_status_id in this line https://github.com/civicrm/civicrm-core/pull/19096/files#diff-9f33a2073e9f844dbb842e0737b7df4bce13db31eabe13b9bdd10e1035dbf6d3R612 has had the empty(->contribution_page_id) bit removed - I can 't think why that would be added in & I think it was discussed out but not removed
|
@monishdeb is this one you could review |
|
r-run on local, worked fine. Reviewed patch, looks good. Merging now. |
ahed-compucorp
added a commit
to ahed-compucorp/civicrm-core
that referenced
this pull request
Jun 28, 2021
Included in CiviCRM 5.40.0 PR: civicrm#20523
ahed-compucorp
added a commit
to compucorp/civicrm-core
that referenced
this pull request
Jun 28, 2021
Included in CiviCRM 5.40.0 PR: civicrm#20523
ahed-compucorp
added a commit
to compucorp/civicrm-core
that referenced
this pull request
Sep 16, 2021
Included in CiviCRM 5.40.0 PR: civicrm#20523
ahed-compucorp
added a commit
to compucorp/civicrm-core
that referenced
this pull request
Sep 16, 2021
Included in CiviCRM 5.40.0 PR: civicrm#20523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a reviewer's cut of #19096
the only substantive difference is the check around the contribution_status_id
in this line https://github.com/civicrm/civicrm-core/pull/19096/files#diff-9f33a2073e9f844dbb842e0737b7df4bce13db31eabe13b9bdd10e1035dbf6d3R612
has had the empty(->contribution_page_id) bit removed - I can't think why that would be added in & I think it was discussed out but not removed
Before
PCP notifiction sent when the pcp is created
After
PCP notification sent when the pcp is created only if the contribution is completed, otherwise when it's completed
Technical Details
Test cover was added back here https://github.com/civicrm/civicrm-core/pull/19117/files#diff-aa980d4314aba8a82734be8870aed0b2378665251746878960410de6dd249918R820 in the test
testSubmitWithPCP()@ahed-compucorp @nishant-bhorodia - this is basically the same as yours with some stylistic differences - but importantly is removes the extra if clause I was concered about here #19096 (comment) - ie the presence of contribution_page_id should be irrelevant
Comments
#20522 is incorporated into this