Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php8-compat] Fix php beautifier notice by conditionally assinging dy… #20509

Merged
merged 1 commit into from
Jun 5, 2021

Conversation

seamuslee001
Copy link
Contributor

…namic foreign key to the template

Overview

This fixes the warnings in a similar vein to #20445

Before

PHP Beautifier warnings generated

After

No warnings

ping @eileenmcnaughton @totten @colemanw @demeritcowboy

@civibot
Copy link

civibot bot commented Jun 4, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

my instinct was to do this instead

   $table['dynamicForeignKey'] = $dynamicForeign ?? '';

but that's bikeshedding

@seamuslee001 seamuslee001 merged commit 1f2aed5 into civicrm:master Jun 5, 2021
@seamuslee001 seamuslee001 deleted the fix_beautifier_notice branch June 5, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants