[php8-compat] Fix issue in APIv3 Where by because product has a colum… #20508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n called options the testCreateSingleValueAlter triggers a cannot access offset of type string on string in php8
|
(Standard links)
|
|
OK - if tests still pass then this is fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n called options the testCreateSingleValueAlter triggers a cannot access offset of type string on string in php8
Overview
This fixes the following error in php8 when running the testCreateSingleValueAlter for the Product entity
Before
Type Error generated in php8
After
No Type Error
Technical Details
The product table has a column called options which clashes with the apiv3 options in this test in annoying ways
ping @eileenmcnaughton @demeritcowboy @colemanw