Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[php8-compat][NFC] Fix using ZipArchive::open on an empty file #20500

Merged
merged 1 commit into from
Jun 5, 2021
Merged

[php8-compat][NFC] Fix using ZipArchive::open on an empty file #20500

merged 1 commit into from
Jun 5, 2021

Conversation

seamuslee001
Copy link
Contributor

Overview

This fixes the following deprecation in php8 ZipArchive::open(): Using empty file as ZipArchive is deprecated

Before

Deprecation issued in php8

After

No deprecation issued

ping @eileenmcnaughton @demeritcowboy @totten

@civibot
Copy link

civibot bot commented Jun 4, 2021

(Standard links)

@civibot civibot bot added the master label Jun 4, 2021
@eileenmcnaughton eileenmcnaughton merged commit 005fa8c into civicrm:master Jun 5, 2021
@eileenmcnaughton eileenmcnaughton deleted the php8_zip_test branch June 5, 2021 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton