[WIP] Add pseudo-entity APIv4 Attachment

[monishdeb]

Overview

A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

[WIP] Technical Details

Declare APIv4 Attachment abstract entity:

• Created CRM_Core_BAO_Attachment which extends CRM_Core_DAO
• Moved all the utility functions from API3 Attachment to BAO fns. Idea is to use the common BAO fns for both APIv3 and APIv4
• declared the CRM_Core_BAO_Attachment::fields which got a combinations of civicrm_file and civicrm_entity_file fields
• all the five pseudo fields (name, field_name, url, path and content) are declared via a separate function CRM_Core_BAO_Attachment::pseudoFields
• Manually return the BAO name for Attachment entity in _civicrm_api3_get_DAO and Civi/Api4/Utils/CoreUtil:: getBAOFromApiName
• Construct the derived table for Attachment entity here Civi/Api4/Utils/CoreUtil::getTableName here
• Add FieldSpec attribute pseudo and setter function (based on this attribute the non-DB fields could be excluded from query)

Api4 Attachment.create/update implementation

...

Api4 Attachment.get implementation

...

Api4 Attachment.delete implementation

...

Comments

Anything else you would like the reviewer to note

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Suggested change

	*
	* @see https://docs.civicrm.org/user/en/latest/organising-your-data/contacts/
	* @searchable primary
	*

[colemanw]

I think the attachment "Get" action might end up being an interesting blend of DAOGetAction and ArrayQueryActionTrait to allow filtering on both real and calculated fields.

[eileenmcnaughton]

@totten @seamuslee001 this is the attachment WIP

On the contact image - I would be inclined to add handling in the attachment api for that field if possible - so it's invisible to api consumers that it is non-standard. I feel like that might pave the way to get calling code switched over and to 'at some point' change the table structure.

[demeritcowboy]

This has conflicts and has been unworked on for several months. Going to close but feel free to reopen.