APIv4 - Cleanup getFields, add @internal flag for non-public field attributes #20489
+37
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| /** | ||
| * @param bool $readonly | ||
| * @return $this | ||
| */ | ||
| public function setreadonly($readonly) { | ||
| public function setReadonly($readonly) { |
There was a problem hiding this comment.
Hmm - what about proper camels setReadOnly - is that inconsistent with other places?
There was a problem hiding this comment.
The property is called "readonly" (all lower case)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cleanup in APIv4 getFields.
Comments
This is in preparation for adding more attributes to each field to designate it's type (Field or Filter), the operators it allows and the list of sql callbacks. My main hesitation to adding all that stuff was bloat in the output of api.getFields so this PR adds a
@internalflag which will give access to those attributes during internal api getFields but hide them from the public api.