Fix Schema calculation of usePrefix to cope with rpow:

[eileenmcnaughton]

Overview

This fixes the code in the logging schema to calculate $usePrefix based on whether the logging database name matches the civicrm database name, not the whole string.

$usePrefix is used to determine whether to prepend the database name in the triggers - ie

Before

database name is prepended into the string when rpow is in play

CREATE TRIGGER civicrm_activity_after_update ... THEN INSERT INTO `civi_database`.log_civicrm_activity 

This would also happen if different db users were used for the 2 databases (I can't think of any reason why they would be) - but the user difference would not flow through in any way.

After

CREATE TRIGGER civicrm_activity_after_update ... THEN INSERT INTO log_civicrm_activity 

Technical Details

Getting usePrefix right helps with portability as we avoid hard-coding the database name unless it is necessary.

The previous code was comparing the whole DSN - which will not match when (rpow)[https://github.com/totten/rpow] is in use. However, we are only using it to determine if the db name is the same (we don't write user or db host into the trigger anyway) & comparing just database gives a better result

Comments

I don't think a reviewer needs to test this in the rpow context - I think that as long as a reviewer experiences this as no change it's fine

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

jenkins retest this please

[eileenmcnaughton]

thanks @demeritcowboy !