Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/financial#6 Added is template to search screen #20451

Merged
merged 6 commits into from
Jun 28, 2021

Conversation

jaapjansma
Copy link
Contributor

@jaapjansma jaapjansma commented May 31, 2021

Overview

This PR adds a field on the contribution search screen to search for template contributions.
By default this is set to no.

This PR is part of the work done for https://lab.civicrm.org/dev/financial/-/issues/6

Before

There was no way to search for template contributions or to exclude them from the search

After

By default template contributions are excluded from the search. Also the user is able to search for them.

In the search result it will also show which contribution is a template and which isn't

Peek 2021-05-28 11-43

Comments

This PR also excludes contributions with is_template = 1 from various custom searches.

See https://lab.civicrm.org/dev/financial/-/issues/6
And https://lab.civicrm.org/dev/core/-/issues/2624

@civibot
Copy link

civibot bot commented May 31, 2021

(Standard links)

@civibot civibot bot added the master label May 31, 2021
@colemanw
Copy link
Member

Any chance of adding a unit test to this?

@jaapjansma
Copy link
Contributor Author

@colemanw I have added a unit test.

@mattwire mattwire merged commit 5b51bc7 into civicrm:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants