dev/financial#6 Do not include template contributions in reports #20450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is part of the work done for https://lab.civicrm.org/dev/financial/-/issues/6
and this part is to exclude template contributions from reports.
Template contributions are part of the recurring contribution and are used to generate followup contributions.
Other PR's will follow soon which will include to creation of the template contribution.
Before
If a contribution with
is_template = 1
existed in the database those will popup in various reports.After
If a contribution with
is_template = 1
existed in the database those will not popup in various reports anymore.Technical Details
I also changed a unit test so that it includes a template contribution and checks whether the template contribution is not counted.
Comments
See https://lab.civicrm.org/dev/financial/-/issues/6
And https://lab.civicrm.org/dev/core/-/issues/2624