[php8-compat] [REF] Fix a couple of functions triggering deprecation notices in php… #20442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@seamuslee001 perhaps we should go the other way - & make them non-optional. That is basically the status quo because calls that did not pass them in currently would fail |
|
@eileenmcnaughton hmm maybe I guess so just remove the defaults then? |
|
Yeah I think so |
…8.0 where by an optional parameter is before required parameters in the function signature
e231bd1 to
b05a747
Compare
|
ok have updated to that now @eileenmcnaughton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…8.0 where by an optional parameter is before required parameters in the function signature
Overview
This fixes a couple of deprecation notices found when installing dmaster on a local php8.0 instance
PHP Deprecated: Required parameter $fieldId follows optional parameter $fieldIdName in /home/seamus/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/DAO.php on line 2014Deprecated: Required parameter $domainSpecific follows optional parameter $fieldName in /home/seamus/buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/OptionValue.php on line 254Before
Deprecation notices emitted in php8.0
After
No deprecation notices emitted for these functions in php8.0
ping @eileenmcnaughton @totten @colemanw