[REF] APIv4 refactoring to support calculated fields #20440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
f5691f8 to
bda2f04
Compare
This allows any fieldSpec provider to change the callback used to build field options, or to add an ad-hoc field not in the schema with its own option getter.
|
test this please |
bda2f04 to
e60149f
Compare
|
Search kit & api explorer still seem to resolve options OK & we have pretty good test cover. I'll also throw this at our wmf unit tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a code refactor to make it possible to add ad-hoc fields to the api getfields spec.
Before
All APIv4 fields correspond to db columns for dao entities for the
getaction.After
It's possible to add other fields. They will be ignored by the get api, so handling will need to be done elsewhere.
Technical Details
A big part of this refactor was to move options lookup to a callback function.