Fix separate payment membership test to create valid financial transa… #20436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
a42c760 to
331245f
Compare
| @@ -2055,10 +2055,6 @@ public static function submit($params) { | |||
| $form->controller = new CRM_Contribute_Controller_Contribution(); | |||
| $params['invoiceID'] = md5(uniqid(rand(), TRUE)); | |||
|
|
|||
| // We want to move away from passing in amount as it is calculated by the actually-submitted params. | |||
There was a problem hiding this comment.
This function is only used by ContributionPage.submit api which is likely only used but the tess
331245f to
d716b24
Compare
…tions The issue is inconsistency on the test side, not the core code
d716b24 to
765d02a
Compare
|
@seamuslee001 are you able to merge this so I can re-test the other change? |
|
I did a long look and I'm pretty confident the tests aren't actually changing here so I think this is all good |
|
thanks @seamuslee001 there is a lot there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix separate payment membership test to create valid financial transactions
This fixes the membership submit tests in this class to be submitting price set values that are valid for the form rather than doing weird test-specific overrides.
I also did a lot of standardisation & cleanup
Before
The various tests to submit the contribution page with membershps were forcing amounts through that didn't relate to the actual price set options selected (or not). As a result efforts to ensure line items, tax and payments added up to the total were failing.
I'd already done a big cleanup but still
After
Consistent and valid values used
Technical Details
There is no actual change to what is tested. The only changes outside tests are really in the test harness - although the order function will be useful if we ever get to cleaning up the rest of that form.
Comments
Note the Order class is commented as not supported for use outside of core and all existing uses of it are well covered by tests