[REF] minor extraction - getInfoUrl

[eileenmcnaughton]

Overview

[REF] minor extraction - getInfoUrl

Before

variable passed around

After

consistent function used

Technical Details

I did a universe search on checkValidEvent & it wasn't called from anywhere else so I made it protected (perhaps private would have been more explicit since this class is inherited)

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

Looks safe to me. For r-run, I did this:

• Open two browsers (one logged in as admin; one anonymous/public).
• (Browser 1/Admin) Go to "Configure Event => Online Registration". Set a registration deadline in the future.
• (Browser 2/Public) Open the event's info page and proceed to registration page. Page looks good.
• (Browser 1/Admin) Move the registration end-date. Now it's expired.
• (Browser 2/Public) Reload registration page. Observe that it redirects and shows an error.

So that seems good. 👍

[eileenmcnaughton]

thanks @totten - it's a pretty small baby step in tidying up some pretty scary code sadly - but I appreciate your review