[REF] Replace deprecated code call #20409
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Replace deprecated code call
Before
Deprecated fn call
After
Technical Details
I hadn't made this change before because the Civi::service() facade means it takes a bit of effort to find the function being called & verify the signature is in fact the same - however I did it this time & it is.
Perhaps as a follow up we should rip through & do all the others - I'm tempted to perhaps add a comment to say what the actually called function is before each line but I guess in theory the Civi facade is dev-friendly
Also I'm very tempted to rip out the check to the url retrieve -
CRM_Utils_Request::retrieve('triggerRebuild', 'Boolean', CRM_Core_DAO::$_nullObject, FALSE, 0, 'GET')
= this seems to me like an undocumented feature that was used by devs when developing the triggers but which devs would do in other ways now...Comments