Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised fix for menu/UI issues for Joomla 4.0 #20401

Merged
merged 5 commits into from
May 25, 2021
Merged

Conversation

vingle
Copy link
Contributor

@vingle vingle commented May 24, 2021

Overview

CiviCRM's below Menubar position is hidden in Joomla 4's new admin theme (1); and at tablet (2) & mobile (3), width, also for wrapped menus (4). There are other issues tidied here: white labels for the search menu (5); padding around the main content; and dashlets sometimes becomming extra wide (6).

Before

image
2.
image
3.
image
4.
image
5.
image

After

image
2.
image
3.
image
4.
image
5.
image

Technical Details

This was tested on Civi 5.37.1 with Joomla 4 Beta 7; as well as Joomla 3.9.26 to check against regressions. The css is namespaced with body.layout-default to prevent styles loading on Joomla 3.x; but in the event Joomla removes that from its body classes in the final J4 release another method will be needed.

Comments

To help testing/debugging, the 1st commit in the PR is the menu, the 3rd removes padding and the 4th fixes the dashlet bug (the 2nd and 5th are spacing/indent tidying – which I didn't notice till checking the diff).

@civibot
Copy link

civibot bot commented May 24, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

@colemanw is this OK now?

@colemanw
Copy link
Member

Yes I think the code comments are good enough for now to distinguish the old from new css. Code location is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants