[REF] Set receipt_date after sending, (from batch) not in anticipation #20395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Set receipt_date after sending, not in anticipation
Before
$contributionID & $membershipID passed around, receipt_date set before receipt is sent (which probably doesn't matter but felt like a bad approach because the contribution id had not been available at that point).
After
Getters added & used
Technical Details
EntryTest has tests
Comments