Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Set receipt_date after sending, (from batch) not in anticipation #20395

Merged
merged 1 commit into from
May 31, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 24, 2021

Overview

[REF] Set receipt_date after sending, not in anticipation

Before

$contributionID & $membershipID passed around, receipt_date set before receipt is sent (which probably doesn't matter but felt like a bad approach because the contribution id had not been available at that point).

After

Getters added & used

Technical Details

EntryTest has tests

Comments

@civibot
Copy link

civibot bot commented May 24, 2021

(Standard links)

@civibot civibot bot added the master label May 24, 2021
@eileenmcnaughton eileenmcnaughton changed the title [REF] Set receipt_date after sending, not in anticipation [REF] Set receipt_date after sending, (from batch) not in anticipation May 25, 2021
@monishdeb
Copy link
Member

Reviewed in local, looks good. Based on:

r-test : PASSED
r-run : PASSED

merging it.

@monishdeb monishdeb merged commit 12c0f98 into civicrm:master May 31, 2021
@eileenmcnaughton
Copy link
Contributor Author

thanks @monishdeb

@eileenmcnaughton eileenmcnaughton deleted the entry2 branch May 31, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants