If paymentprocessor still uses doTransferCheckout/doDirectPayment trigger deprecated function warning

[mattwire]

Overview

Payment processor should override doPayment(). All core processors have now been converted. If not overridden trigger deprecated error before calling deprecated doTransferCheckout()/doDirectPayment().

Before

No deprecated warning if paymentprocessor implements doTransferCheckout/doDirectPayment.

After

Deprecated warning if paymentprocessor implements doTransferCheckout/doDirectPayment.

Technical Details

We added deprecated warnings into the actual functions on CRM_Core_Payment but these don't normally work because the payment processor extension overrides those functions.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).