Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Add in voids to various setUpBeforeClass and tearDownAfterClass… #20365

Merged
merged 1 commit into from
May 20, 2021
Merged

[NFC] Add in voids to various setUpBeforeClass and tearDownAfterClass… #20365

merged 1 commit into from
May 20, 2021

Conversation

seamuslee001
Copy link
Contributor

… functions

Overview

Title says it all

Before

Test classes without voids causes issues on phpunit8

After

No issues

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented May 20, 2021

(Standard links)

@civibot civibot bot added the master label May 20, 2021
@seamuslee001 seamuslee001 merged commit 6402d11 into civicrm:master May 20, 2021
@seamuslee001 seamuslee001 deleted the voidtearDownAfterClass branch May 20, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton