Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Update Pear Validate Finance CreditCard to use latest tagged re… #20351

Merged

Conversation

seamuslee001
Copy link
Contributor

…lease that now includes the improved mastercard 2bin regex

Overview

This updates the composer package reference for pear/validate_finance_creditcard to be 0.7.0 now that a new release has been shipped

Before

working off master branch as no release had the mastercard 2bin in it

After

tagged release with mastercard 2bin in it

ping @eileenmcnaughton @MikeyMJCO @totten

…lease that now includes the improved mastercard 2bin regex
@civibot
Copy link

civibot bot commented May 19, 2021

(Standard links)

@civibot civibot bot added the master label May 19, 2021
@seamuslee001 seamuslee001 merged commit 53bf6cf into civicrm:master May 20, 2021
@seamuslee001 seamuslee001 deleted the update_pear_finance_creditcard branch May 20, 2021 00:09
@totten
Copy link
Member

totten commented May 20, 2021

Huzzah! Huzzah!

@seamuslee001 @MikeyMJCO I wonder if this means we can stop requiring minimum-stability: dev for new builds? If so, we should make this line conditional (ie skip for 5.39+):

https://github.com/civicrm/civicrm-buildkit/blob/f2b82eea80c3af8386e7832ee6f3bd3ce8ba6b9d/src/civibuild.lib.sh#L573

That way, if anything else slips in (requirements where civicrm-core would depend on some unreleased third-party repo), then CI will fail/reject it...

@seamuslee001
Copy link
Contributor Author

@totten possibly but not for a while yet in terms of buildkit as this only gone into master so probably need to wait until we get the new ESR

@homotechsual
Copy link
Contributor

I'm longing for that day too @totten and if we can do it so that we only set minimum stability if the civicrm-core version is >=5.39 that'd work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants