SearchKit - Fix menu permission #20349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
72a506a to
1e74412
Compare
| @@ -18,6 +18,7 @@ public function enable() { | |||
| ->addValue('icon', 'crm-i fa-search-plus') | |||
| ->addValue('has_separator', 2) | |||
| ->addValue('weight', 99) | |||
| ->addValue('permission', 'administer CiviCRM') | |||
…iCRM data' Fixes dev/core#2619 https://lab.civicrm.org/dev/core/-/issues/2619
1e74412 to
919be70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adjust permission in menubar to match permission on page so that non-permissioned users do not see a non-functional link in the menu.
See https://lab.civicrm.org/dev/core/-/issues/2619
Before
Non-admin users see SearchKit menu but when they click on it get "Access Denied"
After
Only admin users see SearchKit in menubar.
Technical Details
Uses the fairly new 'administer CiviCRM data' permission, which is a sub-permission of 'administer CiviCRM'.