Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mandatory keys check fail for value of float 0.0 in a required key in an entity #20342

Merged
merged 2 commits into from
May 20, 2021
Merged

Fix mandatory keys check fail for value of float 0.0 in a required key in an entity #20342

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13a474d
Fix mandatory keys check fail for value of float 0.0
bugfolder May 18, 2021
e746a64
Separate checks for 0.0 and 0
bugfolder May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v3/utils.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ function civicrm_api3_verify_mandatory($params, $daoName = NULL, $keys = [], $ve
else {
// Disallow empty values except for the number zero.
// TODO: create a utility for this since it's needed in many places.
if (!array_key_exists($key, $params) || (empty($params[$key]) && $params[$key] !== 0 && $params[$key] !== '0')) {
if (!array_key_exists($key, $params) || (empty($params[$key]) && $params[$key] !== 0.0 && $params[$key] !== 0 && $params[$key] !== '0')) {
$unmatched[] = $key;
}
}
Expand Down