CiviCRM Scheduled Reminders, Event custom fields are not available as tokens #20334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
992121d to
b4db751
Compare
b4db751 to
a0311b3
Compare
… available as tokens in Scheduled Reminders. Add implementation to TokenProcessor
mlutfy
reviewed
Jul 21, 2021
| '{event.registration_url}' => ts('Event Registration URL'), | ||
| '{event.balance}' => ts('Event Balance'), | ||
| ]; | ||
| static $tokens = NULL; |
There was a problem hiding this comment.
Could you use Civi::$statics instead? I think this will eventually cause problem with tests.
For more information: https://civicrm.org/blog/totten/the-static-is-dead-long-live-the-static
mlutfy
reviewed
Jul 21, 2021
| @@ -1852,7 +1852,7 @@ public static function legacyContactTokens() { | |||
| */ | |||
| public static function getCustomFieldTokens($entity, $usedForTokenWidget = FALSE) { | |||
| $customTokens = []; | |||
| $tokenName = $usedForTokenWidget ? "{contribution.custom_%d}" : "custom_%d"; | |||
| $tokenName = $usedForTokenWidget ? '{' . strtolower($entity) . '.custom_%d}' : 'custom_%d'; | |||
There was a problem hiding this comment.
Could you use mb_strtolower instead? It tends to be more reliable for when running CiviCRM in non-English (well, more specifically when running in Turkish, example: civicrm/civicrm-packages#324).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
CiviCRM Scheduled Reminders, Event custom fields are not available as tokens
Before
Event custom fields are NOT available as tokens in Scheduled Reminders
After
Event custom fields ARE available as tokens in Scheduled Reminders
Technical Details
Comments
Ping @mattwire
Agileware Ref: CIVICRM-1730