Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert AuthorizeNet to doPayment() #20322

Merged
merged 1 commit into from
May 17, 2021
Merged

Convert AuthorizeNet to doPayment() #20322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions CRM/Core/Payment/AuthorizeNet.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,15 +103,29 @@ protected function supportsRecurContributionsForPledges() {
/**
* Submit a payment using Advanced Integration Method.
*
* @param array $params
* Assoc array of input parameters for this transaction.
* @param array|\Civi\Payment\PropertyBag $params
*
* @param string $component
*
* @return array
* the result in a nice formatted array (or an error object)
* Result array (containing at least the key payment_status_id)
*
* @throws \Civi\Payment\Exception\PaymentProcessorException
*/
public function doDirectPayment(&$params) {
public function doPayment(&$params, $component = 'contribute') {
$propertyBag = \Civi\Payment\PropertyBag::cast($params);
$this->_component = $component;
$statuses = CRM_Contribute_BAO_Contribution::buildOptions('contribution_status_id', 'validate');

// If we have a $0 amount, skip call to processor and set payment_status to Completed.
// Conceivably a processor might override this - perhaps for setting up a token - but we don't
// have an example of that at the moment.
if ($propertyBag->getAmount() == 0) {
$result['payment_status_id'] = array_search('Completed', $statuses);
$result['payment_status'] = 'Completed';
return $result;
}

if (!defined('CURLOPT_SSLCERT')) {
// Note that guzzle doesn't necessarily require CURL, although it prefers it. But we should leave this error
// here unless someone suggests it is not required since it's likely helpful.
Expand All @@ -136,6 +150,8 @@ public function doDirectPayment(&$params) {

if (!empty($params['is_recur']) && !empty($params['contributionRecurID'])) {
$this->doRecurPayment();
$params['payment_status_id'] = array_search('Pending', $statuses);
$params['payment_status'] = 'Pending';
return $params;
}

Expand Down Expand Up @@ -179,10 +195,10 @@ public function doDirectPayment(&$params) {
switch ($response_fields[0]) {
case self::AUTH_REVIEW:
$params['payment_status_id'] = array_search('Pending', $contributionStatus);
$params['payment_status'] = 'Pending';
break;

case self::AUTH_ERROR:
$params['payment_status_id'] = array_search('Failed', $contributionStatus);
$errormsg = $response_fields[2] . ' ' . $response_fields[3];
throw new PaymentProcessorException($errormsg, $response_fields[1]);

Expand All @@ -193,11 +209,11 @@ public function doDirectPayment(&$params) {
default:
// Success
$params['trxn_id'] = !empty($response_fields[6]) ? $response_fields[6] : $this->getTestTrxnID();
$params['payment_status_id'] = array_search('Completed', $statuses);
$params['payment_status'] = 'Completed';
break;
}

// TODO: include authorization code?

return $params;
}

Expand Down