Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Add getter for contributionID #20318

Merged
merged 1 commit into from
May 20, 2021
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] Add getter for contributionID

Before

variable passed around

After

Variable retrieved consistently via a function

Technical Details

Comments

@civibot civibot bot added the master label May 17, 2021
@civibot
Copy link

civibot bot commented May 17, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 are you able to merge this - that paypal error validation error you logged is still there in Paypal Pro so I guess a couple more small ones like this need to go through

@seamuslee001
Copy link
Contributor

Looks good to me

@seamuslee001 seamuslee001 merged commit 87ea6c9 into civicrm:master May 20, 2021
@seamuslee001 seamuslee001 deleted the ppp branch May 20, 2021 01:33
@eileenmcnaughton
Copy link
Contributor Author

thanks - I'll check where that file is at now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants