Cleanup tracking on group.load

[eileenmcnaughton]

Overview

Cleanup tracking on group.load

Before

There is a static to determine if it has already been called in the php process and a $force param to by pass it.
Note that if the load is successful the group is updated with detail about it. If not it isn't. The static returns just because we tried whereas it makes more sense to skip based on whether or not the group needs a reload at that moment.

After

Static gone, force deprecated.

Technical Details

1. deprecate force parameter
2. ditch the static & let the db lookups speak for themselves

The force paramter seems to mostly be about the static & probably only exists to support tests.
The static doesn't make sense now because either they group needs loading or it doesn't.
The fact the process might have tried and succeeded or failed before doesn't need
to be recorded in the static

Comments

I suspect some unit tests might need to be adjusted beyond just dropping force but will see the outcome

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 @colemanw I think if we can merge this it will make other tests less flakey

[mattwire]

I've loaded this onto a client site for testing

[seamuslee001]

This makes sense to me the actual code changes look pretty minor here and the test coverage is good here and the test changes are just re-ordering when certain test objects are created. MOP

[eileenmcnaughton]

thanks @mattwire - I am expecting this merge will permit this to pass #20243 which you might like to add to your client site too - it should have a least a potential performance improvement in some edge cases