Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove never-passed parameter from now unshared function #20304

Merged
merged 1 commit into from
May 15, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove never-passed parameter from now unshared parameter

Before

Function is not only used from this one place (+ a couple of tests) but still accepts a param this function never passed

After

param $formDates removed

Technical Details

Comments

@civibot
Copy link

civibot bot commented May 14, 2021

(Standard links)

@civibot civibot bot added the master label May 14, 2021
@eileenmcnaughton eileenmcnaughton changed the title Remove never-passed parameter from now unshared parameter Remove never-passed parameter from now unshared function May 15, 2021
@demeritcowboy
Copy link
Contributor

This looks ok to me. Civimobile-api looks like it calls this function but they don't pass formDate.

@demeritcowboy demeritcowboy merged commit 436a4ca into civicrm:master May 15, 2021
@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy that's pretty terrifying that they call this function - I was going to move it but I'll just copy it & deprecate the original then

@eileenmcnaughton eileenmcnaughton deleted the mem_move2 branch May 16, 2021 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants