dev/core#2593 stop calling loadRelatedObjects / fix for bug #20300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are no longer using ids after this function so we don't need to call that function to load them. In addition this extacts getContribution & reflects the fact the contact_id is only being used to warn if the contribution is not a match (in the debug log)
|
(Standard links)
|
| } | ||
|
|
||
| // CRM-19478: handle oddity when p=null is set in place of contribution page ID, | ||
| if (!empty($ids['contributionPage']) && !is_numeric($ids['contributionPage'])) { |
There was a problem hiding this comment.
Note that this portion (from here down) has simply been removed as $ids is no longer used from here on down (so no point populating them)
The lines above are extracted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#2593 stop calling loadRelatedObjects / fix for bug
Before
Unnecessary call to loadRelatedObjects can sometimes lead to IPNS failing
After
Unnecessary call removed
Technical Details
We are no longer using ids after this function so we don't need to
call that function to load them.
In addition this extacts getContribution & reflects the fact the contact_id
is only being used to warn if the contribution is not a match (in
the debug log)
Comments
@seamuslee001 this technically resolves https://lab.civicrm.org/dev/core/-/issues/2593 I believe - however the same impact would be in PaypalProIPN which I've started the same process on #20294
In addition I think another 60 lines of code could be removed with this merged