Deprecate passing contribution_status_id to Membership::create

[eileenmcnaughton]

Overview

Deprecate passing contribution_status_id to Membership::create

Before

Bad practice acted on quietly

After

Bad practice acted on noisily

Technical Details

I'm fully expecting some test fails first round

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Test fails relate @eileenmcnaughton

[eileenmcnaughton]

CRM_Batch_Form_EntryTest::testProcessMembership with data set #0 ('.')
Use the order api

/home/jenkins/bknix-dfl/build/core-20292-23uts/web/sites/all/modules/civicrm/CRM/Core/Error.php:1053
/home/jenkins/bknix-dfl/build/core-20292-23uts/web/sites/all/modules/civicrm/CRM/Member/BAO/Membership.php:348
/home/jenkins/bknix-dfl/build/core-20292-23uts/web/sites/all/modules/civicrm/CRM/Batch/Form/Entry.php:857
/home/jenkins/bknix-dfl/build/core-20292-23uts/web/sites/all/modules/civicrm/CRM/Batch/Form/Entry.php:1006
/home/jenkins/bknix-dfl/build/core-20292-23uts/web/sites/all/modules/civicrm/tests/phpunit/CRM/Batch/Form/EntryTest.php:180
/home/jenkins/bknix-dfl/build/core-20292-23uts/web/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:228
/home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar:615

[eileenmcnaughton]

Ok - I'm gonna divide & conquer on the batch stuff - #20295