dev/core#2590 - Remove unused function CRM_Utils_File::relativeDirectory #20270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
I didn't get any hits either |
|
Thanks! |
totten
reviewed
May 12, 2021
| } | ||
|
|
||
| // make everything relative from the baseFilePath | ||
| $basePath = self::baseFilePath(); |
There was a problem hiding this comment.
Yay! This removes another reference to ::baseFilePath()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
It's only loosely related to the lab ticket since it came up while pondering.
I could put a deprecatedFunctionWarning call instead but I don't see anywhere in universe that it's used and it's had the deprecated annotation for 2 years.