dev/core#2602 - Installer doesn't check mysql version properly

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/2602

1. Try to install on mariadb 5.5.68 by visiting sites/all/modules/civicrm/install/index.php
2. The requirements checks tell you it's ok even though it should require 5.6.5+

Before

Comparing against a non-existent variable. Crashes if you proceed.

After

Red message. Can't proceed.

Technical Details

When it compares minor versions, it's comparing to $min when it should be comparing to $version (the variable passed into the function).

Comments

I know this is the "legacy" installer, but it's still there and used.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

This looks fine and looks to me to be a copy n paste error merging

[demeritcowboy]

Thanks!