dev/core#2593 [REF] Fix function signature to actually-used variables

[eileenmcnaughton]

Overview

dev/core#2593 [REF] Fix function signature to actually-used variables

Before

$ids is received by completeOrder, $ids['contributionRecur'] is extracted to $contributionRecurID and ids is reset

After

$contributionRecurID is passed to complete order

Technical Details

ids used to hold a whole lotta stuff. Now it just holds contributionRecurID.

This gets rid of ids as a param & just passes contributionRecurID

Note we have made other changes to this signature & it is not called outside of core

Comments

@seamuslee001 another piece in removing that line causing you problems
also @mattwire is familiar with this code

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Makes sense to me test coverage is good here merging