Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Code cleanup, docblocks, strict comparison, type hints #20240

Merged
merged 1 commit into from
May 6, 2021
Merged

[NFC] Code cleanup, docblocks, strict comparison, type hints #20240

merged 1 commit into from
May 6, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[NFC] Code cleanup, docblocks, strict comparison, type hints

Before

Use of == where === possible, lack of hints, exceptions not declared

After

Better practice

Technical Details

Comments

@civibot
Copy link

civibot bot commented May 6, 2021

(Standard links)

@civibot civibot bot added the master label May 6, 2021
@seamuslee001 seamuslee001 merged commit f6c8032 into civicrm:master May 6, 2021
@seamuslee001 seamuslee001 deleted the actnfc branch May 6, 2021 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001