[REF] Cleanup BAO_ActionSchedule::getlist() signature #20239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only called from 3 places. Only one passes variables. Of the 3 2 check if the results is an array - civirules does not (civirules doesn't really use this function - it would be better to do a v4 api get)
|
(Standard links)
|
eileenmcnaughton
commented
May 6, 2021
| @@ -35,32 +35,30 @@ public function preProcess() { | |||
| $mapping = CRM_Utils_Array::first(CRM_Core_BAO_ActionSchedule::getMappings([ | |||
| 'id' => ($this->_isTemplate ? CRM_Event_ActionMapping::EVENT_TPL_MAPPING_ID : CRM_Event_ActionMapping::EVENT_NAME_MAPPING_ID), | |||
| ])); | |||
| $reminderList = CRM_Core_BAO_ActionSchedule::getList(FALSE, $mapping, $this->_id); | |||
| if ($reminderList && is_array($reminderList)) { | |||
There was a problem hiding this comment.
If clause removed - view with w=1
eileenmcnaughton
commented
May 6, 2021
| @@ -126,27 +126,25 @@ public function browse($action = NULL) { | |||
| // Get list of configured reminders | |||
| $reminderList = CRM_Core_BAO_ActionSchedule::getList(); | |||
|
|
|||
| if (is_array($reminderList)) { | |||
There was a problem hiding this comment.
If clause removed - view with w=1
|
|
thanks @demeritcowboy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Cleanup BAO_ActionSchedule::getlist() signature
Before
This is only called from 3 places. Only one passes variables. We have
After
Technical Details
The place where civirules calls this is unaffected as it does not pass parameters and it already expects an array
Comments