dev/core#2583 - Fix fatal error on membership renewal

[jitendrapurohit]

Overview

Backend Membership Renewal returns a fatal error when min fee is empty

Gitlab - https://lab.civicrm.org/dev/core/-/issues/2583

Before

To replicate -

• Create Membership Type with no amount value.
• Create a membership on a contact.
• Renew from the Membership tab.

• Error message when the link is opened in a new window -

After

Fixed.

Technical Details

Return early if the amount is NULL as done in ::format().

Comments

@eileenmcnaughton

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@demeritcowboy also ping you here, I think this is fine here

[eileenmcnaughton]

@jitendrapurohit I was hoping to do the opposite - ie not pass in NULL to the format function - although I'd be fine handling null in that funciton in a deprecated but non-fatal way

[jitendrapurohit]

ok - i think I misunderstood your comment. The original fix was in MembershipRenewal.php. Have updated it now.

[eileenmcnaughton]

thanks @jitendrapurohit - perfect!