[REF] Reverse if statement

[eileenmcnaughton]

Overview

[REF] Reverse if statement

Before

Code sets and then conditionally unsets

After

Code conditionally sets

Technical Details

This splits out a minor code cleanup from #18196 (which is mostly stalled on needs test - #21210 can help with a starting point on that)

I should note that I actually came up with a different result from

https://github.com/civicrm/civicrm-core/pull/18196/files#diff-7117b779a415ec834465eaeffeaddfd50a003a8dab1b11192133adc264960727R60-R63

I compared the two AFTER I created this PR and found the difference. I think mine is right but need some more eyes

• note the || vs the && because it is now

if (hasPermission OR isselfService)

compared to the original

if (!hasPermission && !isSelfService)

EDIT - change of heart - I've altered again - but really this should be partly split to https://github.com/civicrm/civicrm-core/pull/20210/files#diff-7117b779a415ec834465eaeffeaddfd50a003a8dab1b11192133adc264960727R110 so I now have doubts about merging this when that is not merged

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).