Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIv4 - Remove unnecessary class override (handled by generic) #20173

Merged
merged 1 commit into from
Apr 28, 2021
Merged

APIv4 - Remove unnecessary class override (handled by generic) #20173

merged 1 commit into from
Apr 28, 2021

Conversation

colemanw
Copy link
Member

Overview

Removes a custom class no longer needed now that the BasicReplaceAction is generic.

Before

File exists

After

Now it doesn't.

Comments

Existing test coverage is good.

@civibot
Copy link

civibot bot commented Apr 28, 2021

(Standard links)

@civibot civibot bot added the master label Apr 28, 2021
@seamuslee001 seamuslee001 merged commit a886fea into civicrm:master Apr 28, 2021
@seamuslee001 seamuslee001 deleted the noCustomReplace branch April 28, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @seamuslee001