Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Cleanup interaction with membership & membership id #20153

Merged
merged 1 commit into from
May 3, 2021
Merged

[REF] Cleanup interaction with membership & membership id #20153

merged 1 commit into from
May 3, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 26, 2021 •
edited
Loading

Overview

[REF] Cleanup interaction with membership & membership id

This is intended to simplify #20077
by switching to using functions to retrieve membership (as an array) and membershipID
rather than passing around variables

Before

$membership is passed around

After

$membership is retrieved using a function

Technical Details

Comments

@civibot
Copy link

civibot bot commented Apr 26, 2021

(Standard links)

@civibot civibot bot added the master label Apr 26, 2021
@eileenmcnaughton eileenmcnaughton force-pushed the mem branch 5 times, most recently from b097678 to 6bf6956 Compare April 27, 2021 03:06
@eileenmcnaughton
[REF] Cleanup interaction with membership & membership id
bfdf3e2 
This is intended to simplify civicrm#20077
by switching to using functions to retrieve membership (as an array) and membershipID
rather than passing around variables
eileenmcnaughton
eileenmcnaughton commented Apr 27, 2021
View reviewed changes
CRM/Member/Form/Membership.php

// @todo - if we have to figure out if this is for batch processing it doesn't belong in the shared function.
$isBatchProcess = is_a($form, 'CRM_Batch_Form_Entry');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function no longer shared with that form

@eileenmcnaughton eileenmcnaughton mentioned this pull request Apr 27, 2021
Merged
@homotechsual
Copy link
Contributor

(CiviCRM Review Template WORD-1.2)

@seamuslee001 seamuslee001 merged commit a8c7a91 into civicrm:master May 3, 2021
@seamuslee001 seamuslee001 deleted the mem branch May 3, 2021 06:32
@eileenmcnaughton
Copy link
Contributor Author

thanks @MikeyMJCO & @seamuslee001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @homotechsual @seamuslee001