allow event transfer on backend when self-service transfer is disabled

[MegaphoneJon]

https://lab.civicrm.org/dev/event/-/issues/54

Overview

When self-service transfer/cancellation is disabled, back-office transfer/cancellation is also disabled.

Before

Error message: "This event registration can not be transferred or cancelled. Contact the event organizer if you have questions."

After

You can reach the transfer/cancellation screen (which has its own bug, but that's out of scope here).

Technical Details

Pretty sure this regressed on event#35 (aka me).

Comments

I refactored a bunch of this code last year, but there's still some very poor code here. If we move the transfer and cancellation functions from the form layer to the BAO that will improve matters considerably.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@jitendrapurohit is this one you could review?

[seamuslee001]

@Edzelopez I think you will be interested in this one

[Edzelopez]

Thanks @seamuslee001

Applied this one and can confirm it does what is necessary to prevent that error from showing up for admins.

[eileenmcnaughton]

@Edzelopez does that also mean you think the code approach is correct? I am not too familiar with this area of code but the change seems trivial enough & it appears logical so I think it's OK to merge based on it having been tested but would prefer input from you @Edzelopez

Adding merge-ready as we should merge pre-forking ideally

[monishdeb]

I am going to merge this PR as @Edzelopez and I have reviewed the patch and confirmed that it fixes the regression reported in the ticket. Also the extended unit-test captures the use-case accurately.

[eileenmcnaughton]

thanks @monishdeb

[eileenmcnaughton]

@monishdeb sorry - just reading - I wasn't aware this was a regression - do we need to patch the rc?

[monishdeb]

Yeah I think so, should I created PR against 5.37 and/or 5.36 ?

[seamuslee001]

@monishdeb I think just PR against 5.37 given new release is dropped tomorrow

[monishdeb]

Done submitted PR against 5.37 #20223

[lkuttner]

What is the tests/phpunit/CRM/Event/BAO/ParticipantTest.php file and where should it be? I do not find it anywhere on our server.

[MegaphoneJon]

@lkuttner That is part of the CiviCRM test suite, and is only present if you set up CiviCRM in a development context. It's not present in the downloadable versions of CiviCRM, and is unnecessary for normal use. If you're trying to apply this patch you can just ignore that change - its purpose is to ensure that future changes won't cause this bug to reappear.

[lkuttner]

Ah, OK. Thanks @MegaphoneJon. I did patch the Participant.php and do a couple of tests. I don't get the restriction any more, however a transfer results in the creation of a copy of the transferred registration for the new participant, and the original participant is still registered with the status of Registered. This is on 5.33.5 running on Drupal 7.8.2.

[MegaphoneJon]

@lkuttner Do you have a test site? I feel like there were a number of fixes in this area since 5.33, and if you can upgrade a test site to 5.41, it could help identify if there's anything else you need.

[lkuttner]

Yes, our test server is currently is on 5.39.0. I just patched and tested on that, and registrations did transfer properly, so your suspicion was correct. What regular release is/will this update be included in? Thanks!

[MegaphoneJon]

This particular patch was included in 5.38 - but there must be another patch that is also relevant.