SearchKit - Fix display of contact reference fields (single-value) #20117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Thanks. This PR fixes the issue with the contact reference field display. One related query, is there a way to make it clickable? I don't get this contact option in the links drop down. |
This fixes the display of contact reference fields, giving feature parity with other FK fields. Both ID and Display Name are shown as available columns. This does not address the more difficult question of how to join multi-valued contact reference fields with contact display names.
1cbd793 to
ede387b
Compare
|
Ok. I added a unit test so we can merge now based on review & tests passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes the display of contact reference fields, giving feature parity with other FK fields. Both ID and Display Name are shown as available columns.
Ref https://lab.civicrm.org/dev/core/-/issues/2553
Before
ContactRef Display Name column shows error in header and no data.
After
Display name works correctly.
Comments
This does not address the more difficult question of how to join multi-valued contact reference fields with contact display names.