Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Fix installation of the search display table on MySQL 5.36 in t… #20094

Merged

Conversation

seamuslee001
Copy link
Contributor

…ests

Overview

Title says it all

Before

Tests fail on Min profile

After

Tests pass

ping @totten @mattwire @colemanw

@civibot
Copy link

civibot bot commented Apr 18, 2021

(Standard links)

@civibot civibot bot added the 5.37 label Apr 18, 2021
@colemanw
Copy link
Member

colemanw commented Apr 18, 2021

@seamuslee001 thanks for the fix. Can you explain what's going on here? That sql was made with GenCode - have there been recent changes since I made the extsension?

@seamuslee001
Copy link
Contributor Author

@colemanw the issue seems to be that there is a DB unknown error caused by an index or something being too large. This is also consistent with other patches e.g.

$table['attributes'] = $table['attributes'] . ' ROW_FORMAT=DYNAMIC';
I would have thought the attributes might have been picked up here but maybe not. Maybe civix does things differently to the core codeGen

@colemanw colemanw merged commit 6ab0151 into civicrm:5.37 Apr 19, 2021
@colemanw
Copy link
Member

I'm happy to merge, but since this is an autogenerated file we'd need to update whatever generated it so it doesn't get overwritten again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants