dev/core#2509 - Search kit display link for grant view is wrong

[demeritcowboy]

Overview

Came up during https://lab.civicrm.org/dev/core/-/issues/2509.

If you create a search kit search on grants and make a display table and make one of the fields a link to Grant View, it's the wrong link.

Note also that unless the search includes a contact-related column the generated link has the literal [contact_id] in it which fatals when visited, and the link requires a contact id. This PR doesn't address that, but good to know for review purposes.

Before

Missing civicrm

After

Civified

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

I'll merge this as the "before" version was clearly wrong.

The issue of [contact_id] is a bit complex and there are 2 sides to it:

SearchKit side: In the current design, links can pull data from the search but they can't "push" search params to ensure they get the data they need. The current compromise is that "id" always gets pushed onto the params.

Civi side: Ideally, a link to view/edit/delete any entity would require only the id. Maybe some cases (like e.g., cases) are more complex, but in this instance I see no reason why grants need the extra contact_id argument, they can probably just look it up.

[demeritcowboy]

Thanks!