Move tpl assignment to email function #20013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
reviewed
Apr 9, 2021
| @@ -1600,6 +1596,10 @@ protected function emailMembershipReceipt($formValues, $membership) { | |||
| $this->assign('is_pay_later', 0); | |||
| $this->assign('isPrimary', 1); | |||
| } | |||
| //insert financial type name in receipt. | |||
| $formValues['contributionType_name'] = CRM_Core_DAO::getFieldValue('CRM_Financial_DAO_FinancialType', | |||
There was a problem hiding this comment.
just a general urgh here for the variable
There was a problem hiding this comment.
@seamuslee001 just hold your nose & look away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Move tpl assignment to email function
Before
Value is added to formValues & passed around until it gets where it may be needed
After
value is loaded in the function for sending an email (which is where it may be needed, if an email is to be sent) -the value is referenced in the message template (yuck)
Technical Details
Comments