Fix Payment.create to update (recalculate) contribution fee_amount #20008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
This recalculates the fee amount when a payment is received. Our data integrity expects the fee amount on the contribution to equal the sum of the fee amount on the payments. However, it's possible a pending contribution has an 'estimated' fee amount so we can't just add on the fee_amount and assume it will be right
c4d8afb to
dbdad83
Compare
|
This looks like the right approach - it is probably the fix for this issue too: https://lab.civicrm.org/extensions/stripe/-/issues/267 |
|
@mattwire I was assuming the reason Ana pinged you on chat was because she thought it related to Stripe |
|
@mattwire I have tested the patch in my local and does the right thing by recalculating the fee and net amount. Also there is a uni-test which passed. Is there any concern which need to be addressed before merging this PR? |
|
@monishdeb No, just needed a review which you have now done :-) |
|
thanks @mattwire @monishdeb |
olayiwola-compucorp
added a commit
to compucorp/civicrm-core
that referenced
this pull request
Aug 3, 2021
… is created Included CiviCRM 5.38.0 PR: civicrm#20008
olayiwola-compucorp
added a commit
to compucorp/civicrm-core
that referenced
this pull request
Aug 3, 2021
Included CiviCRM 5.38.0 PR: civicrm#20008
olayiwola-compucorp
added a commit
to compucorp/civicrm-core
that referenced
this pull request
Aug 3, 2021
Included CiviCRM 5.38.0 PR: civicrm#20008
olayiwola-compucorp
added a commit
to compucorp/civicrm-core
that referenced
this pull request
Aug 9, 2021
Included CiviCRM 5.38.0 PR: civicrm#20008
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a bug identified by @ananelson (I think) on chat whereby adding a payment to a contribution does not update the contributions fee_amount
Before
Payment create does not alter fee_amount & net_amount at the contribution level
After
Payment create forces a recalculate of fee_amount & net_amount based on the sum of the payments
Technical Details
Our data integrity expects the fee amount on the contribution to equal the sum of the fee amount on the payments. However, it's possible a pending contribution has an 'estimated' fee amount so we can't just add on
the fee_amount and assume it will be right.
I had some different thoughts about how to calculate the fee amount but I also hit some gaps when I tried so this approach seems simple & the test locks it in
Comments
@mattwire @monishdeb