Possible upgrade message mitigation

[eileenmcnaughton]

Overview

Not sure if this is a good idea or not but I'm trying to think about
https://lab.civicrm.org/dev/core/-/issues/2474 and what we can possiby do
to help people with weird DBs

I don't think this error has to be fatal - the situation is likely not worse than before if it fails

@totten @seamuslee001 @colemanw

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thoughts:

1. This may be fixed by Fix loop #19858 (comment), which wouldn't have been in the version in the lab ticket.
2. postupgradeMessage is actually called at the START of the upgrade process and can't report on anything that happens during the upgrade steps. I've come up against this a couple times.

[eileenmcnaughton]

Oh yeah - I had flushed that creepiness from my mind.

I guess the try catch might make sense but there would be no feedback

[eileenmcnaughton]

Closing for now - can still be a discussion piece closed but it is not reviewable