Fix scrollbars on fullscreen dashboard dashlet #19981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently angular dialogService expects templates to be wrapped in an outer div, as that becomes the .ui-dialog-content element.
|
(Standard links)
|
|
@twomice can you test? |
|
We had similar issue on 5.35.1, applied the patch and its working! |
|
Merging based on review |
|
Thanks for the quick fix @colemanw! (Also eileen and pradeep!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the bug described in https://lab.civicrm.org/dev/core/-/issues/2513
Before
Clicking the "expand" arrows on a dashboard dashlet appears cut-off with no scrollbars.
After
Dialog appears with proper size, position, and scrollbars.
Technical Details
Apparently angular dialogService expects templates to be wrapped in an outer div, as that becomes the
.ui-dialog-contentelement.