Fix re-calculation of payment dates on pledge

[jitendrapurohit]

Overview

Fix re-calculation of payment dates on pledge

Before

Payment schedule on the pledge is not recalculated when the start date is changed on a pending pledge. To replicate -

• Create a pledge of $1200 for 12 installments to start on 4th April, 2021.
• The pledge payments will be created for 4th April, 4 May, 4 June...
• Update the pledge start date to 1st May (instead of 4th April) => Save.
• The pledge payment dates are unchanged and are still starting from 4 April, 4 May....

After

If the pledge start date is changed to 1st May, the payment dates are recalculated and are updated to start fro 1st May, 1st June, 1st July....and so on.

Technical Details

This PR partially reverts #19297.

isPaymentsRequireRecalculation() checks the existing db values of the pledge and returns true only if it mismatches the filled values.

19297 moved the call AFTER the pledge is saved. So it is now comparing the "updated" values with the passed params which will always match and hence no recalculation is done in any case.

Comments

@eileenmcnaughton thoughts?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@jitendrapurohit your analysis makes sense - let's see how jenkins feels about it

[megaphonetech-dennis]

• General standards
  • Explain (r-explain)
    • PASS : The goal/problem/solution have been adequately explained in the PR.
  • User impact (r-user)
    • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.
  • Documentation (r-doc)
    • PASS: The changes do not require documentation.
  • Run it (r-run)
    • PASS: I replicated the issue as described by the author and confirmed the buggy behavior. I downloaded and applied the patch. I then created a few additional pledges, made edits to those pledges, and reviewed the payment schedules. Everything appeared correct.

[eileenmcnaughton]

Thank you @megaphonetech-dennis for the review - I'm happy to merge based on your analysis.

Thanks for the patch @jitendrapurohit

[eileenmcnaughton]

This should really have gone against the rc to be in 5.36 #19990